From b461cf5ad12cf675619f7945dd9d6538ca778e82 Mon Sep 17 00:00:00 2001 From: Caleb Campbell Date: Sat, 11 Oct 2025 21:11:14 +1100 Subject: [PATCH] Addressed review comments. Modified setting hide functionality and updated manifest version. --- manifest.json | 4 ++-- src/local-bible-ref-setting-tab.ts | 11 +++++++---- styles.css | 5 ++--- 3 files changed, 11 insertions(+), 9 deletions(-) diff --git a/manifest.json b/manifest.json index cc79f0b..c42df08 100644 --- a/manifest.json +++ b/manifest.json @@ -1,8 +1,8 @@ { "id": "local-bible-ref", "name": "Local Bible Ref", - "version": "1.1.5", - "minAppVersion": "0.15.0", + "version": "1.1.7", + "minAppVersion": "1.9.14", "description": "Quickly and easily reference Bible passages stored locally in your vault.", "author": "Caleb Campbell", "authorUrl": "https://mastodon.social/@calebcampbell", diff --git a/src/local-bible-ref-setting-tab.ts b/src/local-bible-ref-setting-tab.ts index 8c3044a..35d61ea 100644 --- a/src/local-bible-ref-setting-tab.ts +++ b/src/local-bible-ref-setting-tab.ts @@ -26,9 +26,9 @@ export default class LocalBibleRefSettingTab extends PluginSettingTab { .onChange(async (value) => { // toggle visibility of default version setting if (value) { - defaultVersionSetting.settingEl.style.display = 'flex'; + defaultVersionSetting.settingEl.removeClass('hidden'); } else { - defaultVersionSetting.settingEl.style.display = 'none'; + defaultVersionSetting.settingEl.addClass('hidden'); (defaultVersionSetting.components[0] as TextComponent).inputEl.value = ''; this.plugin.settings.defaultVersionShorthand = ''; } @@ -70,8 +70,11 @@ export default class LocalBibleRefSettingTab extends PluginSettingTab { new VersionSuggest(this.app, text.inputEl, this.plugin.settings); }); - defaultVersionSetting.settingEl.style.display = - this.plugin.settings.biblesPath ? 'flex' : 'none'; + if (this.plugin.settings.biblesPath) { + defaultVersionSetting.settingEl.removeClass('hidden'); + } else { + defaultVersionSetting.settingEl.addClass('hidden'); + } new Setting(containerEl) .setName('Default passage format') diff --git a/styles.css b/styles.css index 31fabc5..c203748 100644 --- a/styles.css +++ b/styles.css @@ -1,4 +1,3 @@ -.callout[data-callout="bible"] { - --callout-color: var(--callout-quote); - --callout-icon: lucide-book-open-text; +div.setting-item.hidden { + display: none; } \ No newline at end of file