lwoodard/Custom-Local-Bible-Ref
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Addressed review comments. Modified setting hide functionality and updated manifest version.

Browse Source
This commit is contained in:
Caleb Campbell
2025-10-11 21:11:14 +11:00
parent 6c83e97297
commit b461cf5ad1
3 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
manifest.json
View File

@@ -1,8 +1,8 @@
{ {
"id": "local-bible-ref", "id": "local-bible-ref",
"name": "Local Bible Ref", "name": "Local Bible Ref",
"version": "1.1.5", "version": "1.1.7",
"minAppVersion": "0.15.0", "minAppVersion": "1.9.14",
"description": "Quickly and easily reference Bible passages stored locally in your vault.", "description": "Quickly and easily reference Bible passages stored locally in your vault.",
"author": "Caleb Campbell", "author": "Caleb Campbell",
"authorUrl": "https://mastodon.social/@calebcampbell", "authorUrl": "https://mastodon.social/@calebcampbell",

11
src/local-bible-ref-setting-tab.ts
View File

@@ -26,9 +26,9 @@ export default class LocalBibleRefSettingTab extends PluginSettingTab {
.onChange(async (value) => { .onChange(async (value) => {
// toggle visibility of default version setting // toggle visibility of default version setting
if (value) { if (value) {
defaultVersionSetting.settingEl.style.display = 'flex'; defaultVersionSetting.settingEl.removeClass('hidden');
} else { } else {
defaultVersionSetting.settingEl.style.display = 'none'; defaultVersionSetting.settingEl.addClass('hidden');
(defaultVersionSetting.components[0] as TextComponent).inputEl.value = ''; (defaultVersionSetting.components[0] as TextComponent).inputEl.value = '';
this.plugin.settings.defaultVersionShorthand = ''; this.plugin.settings.defaultVersionShorthand = '';
} }
@@ -70,8 +70,11 @@ export default class LocalBibleRefSettingTab extends PluginSettingTab {
new VersionSuggest(this.app, text.inputEl, this.plugin.settings); new VersionSuggest(this.app, text.inputEl, this.plugin.settings);
}); });
defaultVersionSetting.settingEl.style.display = if (this.plugin.settings.biblesPath) {
this.plugin.settings.biblesPath ? 'flex' : 'none'; defaultVersionSetting.settingEl.removeClass('hidden');
} else {
defaultVersionSetting.settingEl.addClass('hidden');
}
new Setting(containerEl) new Setting(containerEl)
.setName('Default passage format') .setName('Default passage format')

5
styles.css
View File

@@ -1,4 +1,3 @@
.callout[data-callout="bible"] { div.setting-item.hidden {
--callout-color: var(--callout-quote); display: none;
--callout-icon: lucide-book-open-text;
} }